{Storage} Grant proper access on azcopy installation #21714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelyn-ys
requested review from
calvinhzy,
jsntcy and
zhoxing-ms
as code owners
ghost
added
the
ghost
requested a review
from 
Collaborator
|
Storage |
jiasli
approved these changes
Mar 21, 2022
calvinhzy
approved these changes
Mar 22, 2022
jiasli
reviewed
Aug 24, 2022
| try: | ||
| os.chmod(install_dir, | ||
| os.stat(install_dir).st_mode | stat.S_IWUSR | stat.S_IWGRP | stat.S_IWOTH) | ||
| os.chmod(install_dir, os.stat(install_dir).st_mode | stat.S_IWUSR) |
Member
There was a problem hiding this comment.
It seems stat.S_IWUSR is set by default:
import os
import stat
install_dir = 'temp'
os.makedirs(install_dir)
print(bool(os.stat(install_dir).st_mode & stat.S_IWUSR))Output:
True
stat.S_IWUSR is not explicitly set when downloading bicep CLI:
azure-cli/src/azure-cli/azure/cli/command_modules/resource/_bicep.py
Lines 104 to 106 in 9464462
Draft
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #16814, we have granted write access to azcopy installation directory.
But the scope
stat.S_IWUSR | stat.S_IWGRP | stat.S_IWOTHis larger than necessary. Changed the scope tostat.S_IWUSRonly.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.